Fix encoding issues when writing non-ASCII content #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanquanz this should fix your issue 🙏 |
paracycle
reviewed
Apr 4, 2022
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-fix-sigil-encoding
branch
from
e9367c0
to
8fa8197
Compare
vinistock
approved these changes
Apr 5, 2022
paracycle
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug reported here: Shopify/tapioca#881.
I traced the problem to a combination of writing the content without specifying an
encodinghere whileEncoding.default_internalis set toEncoding::UTF_8by Rails here.In these circumstances, writing the new RBI content will fail if it contains UTF-8 characters.