Preserve empty lines when using spoom bump
#124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
reviewed
Mar 31, 2022
Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com>
|
@bravehager I just released spoom 1.1.10 with your fix 👍 Thanks you again 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #118
Right now, Spoom will remove empty lines after bumping files. My guess is most codebases wouldn't be affected because of enforced magic comments such as
# frozen_string_literal: true.Before:
After:
Adjusting the type sigil regex to only match on horizontal whitespace (tabs and spaces) seems to fix the issue, although there could be additional edge cases to consider.