Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment status not updating in GitHub #1311

Open
pcothenet opened this issue Jul 3, 2023 · 3 comments
Open

Deployment status not updating in GitHub #1311

pcothenet opened this issue Jul 3, 2023 · 3 comments

Comments

@pcothenet
Copy link
Contributor

Hi team shipit! Thanks a lot for your great work on this tool!

Since last week, our shipit instance isn't updating the status of the deployment in GitHub anymore.

The deploys are still working as expected:
Screenshot 2023-07-03 at 9 57 05 AM

Yet, the Deployment status stays in "Pending" in GitHub:
Screenshot 2023-07-03 at 9 17 12 AM

  • All webhooks are being received and acted on properly.
  • The deployment gets created properly in GitHub, so we don't think it is a deployment issue.

In logs, we can see the following error, with a timing corresponding to the end of a deploy.

Couldn't find template for digesting: statuses/status

Things we have tried so far that haven't helped:

  • Recreating the stack in shipit
  • Deleting the environment in GitHub
  • Resetting the git cache

Another thing of note is that the issue started happening at the same time as the big GitHub outages of last week, and also correlates with some instability of our shipit hosting.

Any ideas what might be causing this and how to fix it?

@benlangfeld
Copy link
Contributor

commit_deployment_statuses.github_id needs to be a bigint rather than an int. Github got too big.

@pcothenet pcothenet reopened this Jul 3, 2023
@pcothenet
Copy link
Contributor Author

@benlangfeld I added a migration to our instance and that did the trick, thanks for the pointer. I'll try to open a PR to add to the repo.

@benlangfeld
Copy link
Contributor

Credit goes to @ryanmrodriguez for tracking this one down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants