Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identical Stacks can interfere with each other's Merge Queue #1121

Open
eldad87 opened this issue Nov 17, 2020 · 1 comment
Open

Identical Stacks can interfere with each other's Merge Queue #1121

eldad87 opened this issue Nov 17, 2020 · 1 comment

Comments

@eldad87
Copy link

eldad87 commented Nov 17, 2020

Currently,
I'm able to create 2 stacks for the same repo & branch.
If Merge-Queue is enabled on both, they can interfere with each other.

Suggestion:
Merge-Queue can be enabled only once for a given set of Repo & Branch, regardless of the stack environment.

module Shipit
  class Stack < Record
    module NoDeployedCommit

...

    validates :merge_queue_enabled, uniqueness: {
        scope: %i(repository branch),
        message: 'cannot be used more than once with this repository and branch. Check (archived) stacks.'
    }

...
@eldadvcita
Copy link

For backward compatibility, I can add a flag that indicates if this validation should be enforced.
The flag can be added to the repository module: "Single CI per branch".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants