Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(producer): return errors for every message in retryBatch to avoid producer hang forever #2378

Merged
merged 3 commits into from
Dec 22, 2022

Conversation

cch123
Copy link
Contributor

@cch123 cch123 commented Nov 6, 2022

This fixes #2377

@cch123
Copy link
Contributor Author

cch123 commented Nov 6, 2022

CLA signed

@cch123 cch123 closed this Nov 6, 2022
@cch123 cch123 reopened this Nov 6, 2022
Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this issue and submitting the fix, this change looks good to me

@dnwe
Copy link
Collaborator

dnwe commented Nov 14, 2022

@cch123 do you think you might be able to add a functional test that covers this scenario?

@cch123
Copy link
Contributor Author

cch123 commented Nov 19, 2022

@cch123 do you think you might be able to add a functional test that covers this scenario?

let me think about it.. I think the backoff param also didn't work, and need some time to find out why...

@cch123 cch123 closed this Dec 19, 2022
@cch123 cch123 reopened this Dec 19, 2022
@cch123
Copy link
Contributor Author

cch123 commented Dec 19, 2022

@dnwe PTAL

@cch123
Copy link
Contributor Author

cch123 commented Dec 19, 2022

The backoff bug will be fixed in another PR

@dnwe dnwe added the fix label Dec 21, 2022
@dnwe dnwe merged commit 67d977b into IBM:main Dec 22, 2022
@dnwe
Copy link
Collaborator

dnwe commented Dec 22, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idempotent+batch can cause producer hang when broker restart or slow leader election
3 participants