Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent metrics leak with cleanup #2340

Merged
merged 1 commit into from Sep 20, 2022
Merged

Conversation

auntan
Copy link
Contributor

@auntan auntan commented Sep 16, 2022

All metrics must be unregistered to avoid memory leak
Keep track all component metrics and unregister them when closed

This is a copy of this MR with the CLA email corrected
#2338

Keep track all components metrics and unregister them on close
@dnwe
Copy link
Collaborator

dnwe commented Sep 20, 2022

@auntan thanks for looking at this — changes look good to me 👍

@dnwe dnwe merged commit d0a00ae into IBM:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants