fix(consumer): avoid pushing unrelated responses to paused children #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Panos Koutsovasilis <koutsobill@hotmail.com>
dnwe
force-pushed
the
fix-unrelated-responses-paused-child
branch
from
58370f3
to
3c463f8
Compare
|
@pkoutsovasilis thanks — the change looks good, although I wonder if we need to add a functional test that exercises the Pause and Resume functionality as it feels like we have a gap in testing there Is that something you might be available to look into? |
|
@dnwe thanks for the reply, sure I can have a look in testing of Pause and Resume. Is this something that you want it to be part of this PR or a seperate one? |
|
@pkoutsovasilis happy for it to be handled separately — I'll go ahead and review and merge this fix. Thanks again! |
dnwe
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue.
Signed-off-by: Panos Koutsovasilis koutsobill@hotmail.com