fix: correct bugs in DescribeGroupsResponse #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support decoding V0 and V1 "ConsumerProtocolSubscription" types in the DescribeGroupsResponse member metadata (i.e., the new "OwnedPartition" values that may be included by a KIP-429 consumer) - add workaround for the legacy bsm/sarama-cluster client which incorrectly set V1 in its JoinGroup request, but doesn't include the new V1+ fields! https://github.com/bsm/sarama-cluster/blob/d5779253526cc8a3129a0e5d7cc429f4b4473ab4/consumer.go#L644-L648 - also guard GetMemberAssignment and GetMemberMetadata from panic'ing when the fields are empty, which they will be in certain scenarios such as non-stable groups or clients without any assigned topicpartitions
bai
approved these changes
Jan 13, 2022
This was referenced Jan 19, 2022
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DescribeGroupsResponse member metadata (i.e., the new "OwnedPartition"
values that may be included by a KIP-429 consumer)
incorrectly set V1 in its JoinGroup request, but doesn't include the
new V1+ fields!
https://github.com/bsm/sarama-cluster/blob/d5779253526cc8a3129a0e5d7cc429f4b4473ab4/consumer.go#L644-L648
when the fields are empty, which they will be in certain scenarios
such as non-stable groups or clients without any assigned
topicpartitions