Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sarama: remove deprecated tls options from test #1763

Merged
merged 1 commit into from Jul 27, 2020
Merged

sarama: remove deprecated tls options from test #1763

merged 1 commit into from Jul 27, 2020

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Jul 26, 2020

tls.Config.BuildNameToCertificate() is deprecated. godoc advises:

// Deprecated: NameToCertificate only allows associating a single certificate with a given name. Leave that field nil to let the library select the first compatible chain from Certificates.

This removes both uses of it from doListenerTLSTest()

@alrs alrs requested a review from bai as a code owner July 26, 2020 04:01
@d1egoaz d1egoaz merged commit c35e7c5 into IBM:master Jul 27, 2020
@d1egoaz
Copy link
Contributor

d1egoaz commented Jul 27, 2020

thanks @alrs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d1egoaz d1egoaz d1egoaz approved these changes

@bai bai Awaiting requested review from bai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alrs @d1egoaz