Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mock sync producer does not handle the offset while sending messages #1747

Merged
merged 1 commit into from Jan 12, 2021

Conversation

XSAM
Copy link
Contributor

@XSAM XSAM commented Jul 10, 2020

Mock sync producer does not handle the offset while invoking SendMessages.

e.g.

mockSyncProducer := mocks.NewSyncProducer(t, sarama.NewConfig())

msgs := []*sarama.ProducerMessage{
	{Key: sarama.StringEncoder("foo")},
}
mockSyncProducer.SendMessages(msgs)
// Print offset
print(msgs[0].Offset)

@XSAM XSAM requested a review from bai as a code owner July 10, 2020 08:38
@XSAM
Copy link
Contributor Author

XSAM commented Dec 16, 2020

@bai @d1egoaz Shall we merge it?

@d1egoaz d1egoaz merged commit 80667b9 into IBM:master Jan 12, 2021
@XSAM XSAM deleted the fix/mocks-sync-producer branch January 12, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants