Use gofork for encoding/asn1 to fix ASN errors during Kerberos authentication #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
This reverts commit bfff38f.
kvch
force-pushed
the
revert-removing-for-of-asn1
branch
from
4676717
to
c033597
Compare
|
Is there anyone who could help me with fixing the errors on the CI? Locally everything passes. Maybe @bai? |
|
/cc @d1egoaz |
|
I've re-run CI and it's working now, I think it was some Github issue |
d1egoaz
approved these changes
May 22, 2020
|
As mentioned in other issues/prs: I suspect the reason this broke things is because the fork returned its own asn1.ObjectType, which the stdlib marshalled differently, since it was not a stdlib asn1.ObjectType. To re-apply this patch, you would need to do asn1.ObjectType(gssapi.OIN(.... |
|
Alternatively, since this is marshalling a constant slice, the result of the marshal could just be hardcoded into place ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bfff38f.
Closes #1658