testfix: give kafka longer to startup #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason we'd ended up with quite a short (10s) limit on waiting for Kafka to startup and open its listener and since moving from Travis to GitHub actions, this can periodically take longer causing the build to abort early. Bump it up to 2m and tweak a couple of other parts of the boot script.
d1egoaz
approved these changes
May 7, 2020
| while ! nc -q 1 localhost 2181 </dev/null; do echo "Waiting"; sleep 1; done | ||
| while ! nc -q 1 localhost 9092 </dev/null; do echo "Waiting"; sleep 1; done | ||
| while ! nc -q 1 localhost 2185 </dev/null; do echo "Waiting"; sleep 1; done | ||
| while ! nc -q 1 localhost 9095 </dev/null; do echo "Waiting"; sleep 1; done |
There was a problem hiding this comment.
Were these ports change intended ?
There was a problem hiding this comment.
Yeah these nc polls are waiting for toxiproxy to have completed its startup. However, it starts 5 zookeeper listeners and 5 kafka listeners so it makes sense to poll the highest port numbers (which are created last) for zk-5 and kafka-5 respectively
| RC=1 | ||
| set +x | ||
| printf "Waiting for Kafka to become available." | ||
| printf "Waiting for kafka5 to become available." |
There was a problem hiding this comment.
Is the 5 intended or a typo?
There was a problem hiding this comment.
Intended, the nc poll in this block is only querying the fifth broker in the cluster, known as "kafka5" in the toxiproxy config and toxi port 9095 --> kafka port 29095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason we'd ended up with quite a short (10s) limit on waiting
for Kafka to startup and open its listener and since moving from Travis
to GitHub actions, this can periodically take longer causing the build
to abort early. Bump it up to 2m and tweak a couple of other parts of
the boot script.