Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tls ServerName to fix issue: either ServerName or InsecureSkipVerify must be specified in the tls.Config #1692

Merged
merged 2 commits into from May 7, 2020

Conversation

d1egoaz
Copy link
Contributor

@d1egoaz d1egoaz commented May 7, 2020

fixes #1691

TBH I'm not sure if this is enough.

There was a big change here:
https://github.com/Shopify/sarama/pull/1666/files#diff-019034382244c82f15c92490660e4a18
s/tls.DialWithDialer/tls.Client

and all code that was in tls.DialWithDialer is not in tls.Client, so no handshake, timeouts, etc.
https://github.com/golang/go/blob/go1.14.2/src/crypto/tls/tls.go#L102

@d1egoaz d1egoaz requested a review from bai as a code owner May 7, 2020 18:18
@d1egoaz d1egoaz requested a review from dnwe May 7, 2020 18:19
broker.go Outdated Show resolved Hide resolved
@d1egoaz d1egoaz merged commit 273a3f2 into master May 7, 2020
@d1egoaz d1egoaz deleted the diego_fix-tls-set-server-name branch May 7, 2020 19:37
@d1egoaz d1egoaz changed the title Set ServerName using tls.DialWithDialer approach Set tls ServerName to fix issue: either ServerName or InsecureSkipVerify must be specified in the tls.Config May 7, 2020
@d1egoaz
Copy link
Contributor Author

d1egoaz commented May 7, 2020

Thanks for being around @dnwe

bai added a commit to linkedin/Burrow that referenced this pull request May 11, 2020
bai added a commit to linkedin/Burrow that referenced this pull request May 11, 2020
swade1987 added a commit to eeveebank/burrow that referenced this pull request May 15, 2020
* Add SASL-SCRAM ability to Kafka connection

This PR adds the ability to connect to Kafka via SASL-SCRAM 256 or 512

It adds an entry in the SASL Profile configuration called
key=mechanism
value type=string
required=no
default value=(empty)
Which accepts either values SCRAM-SHA-256, SCRAM-SHA-512

Partially addresses linkedin#526

* Ignore ZooKeeper znode Create if the path already exists

Currently, Burrow will attempt to create the znode used by Burrow on startup
This will cause problems if there is authentication needed when connecting
to zk.

The fix is to ignore creating zk node paths if it already exists

* Yext specific Dockerfile

the config file and dir used by Burrow is updated for M4 and Khan

* Update module and import references

go build -o build/Burrow github.com/rjh-yext/Burrow
pulls in linkedin's branch of Burrow

Changing references of linkedin to current fork

* Fix Travis CI build.

* Add Prometheus Metrics Exporter

* Add support for Kafka 2.5.0 anf Go 1.14

* NameToCertificate only allows associating a single certificate with a given name. Leave that field nil to let the library select the first compatible chain from Certificates.

* Update sarama with a fix for IBM/sarama#1692

* Removing CI jobs from upstream merge.

Co-authored-by: Roger Hwang <rhwang@yext.com>
Co-authored-by: rjh-yext <59895513+rjh-yext@users.noreply.github.com>
Co-authored-by: klDen <kl@kenzymele.com>
Co-authored-by: Michael Wain <michaelwain1990@gmail.com>
Co-authored-by: Vlad Gorodetsky <v@gor.io>
Co-authored-by: Vlad Gorodetsky <17348+bai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants