Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce build matrix #1688

Merged
merged 1 commit into from May 6, 2020
Merged

Reduce build matrix #1688

merged 1 commit into from May 6, 2020

Conversation

bai
Copy link
Contributor

@bai bai commented May 6, 2020

Short-term workaround to address build flakiness.

@bai bai requested a review from dnwe May 6, 2020 08:34
@dnwe
Copy link
Collaborator

dnwe commented May 6, 2020

@bai i think we'd still want/need both the push and pr type of build as doesn't that alter that code under test? Head of the branch vs merged into master state?

/pr builds automerged state (as if you merged the PR and ran the tests on that, note: it won't run if the PR can't be automerged).
/push builds for the current state of the branch you pushed to (as if you ran the tests on your local copy you just pushed),

@dnwe dnwe merged commit 8fe9db2 into master May 6, 2020
@bai bai deleted the reduce-build-matrix branch January 16, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants