Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix config.net.keepalive #1643

Merged
merged 2 commits into from
Mar 20, 2020
Merged

fix config.net.keepalive #1643

merged 2 commits into from
Mar 20, 2020

Conversation

kzinglzy
Copy link
Contributor

According to https://github.com/golang/go/blob/master/src/net/dial.go#L81

tcp keepalive is ENABLED when KeepAlive is set to 0 by default

@kzinglzy kzinglzy requested a review from bai as a code owner March 17, 2020 07:40
@ghost ghost added the cla-needed label Mar 17, 2020
bai
bai reviewed Mar 17, 2020
View reviewed changes
config.go Outdated Show resolved Hide resolved
@ghost ghost removed the cla-needed label Mar 17, 2020
@bai
Copy link
Contributor

bai commented Mar 17, 2020

Thanks for contributing 🙏

@kzinglzy kzinglzy changed the title fix config.net.keepalive document fix config.net.keepalive Mar 17, 2020
@bai bai merged commit 18d3a27 into IBM:master Mar 20, 2020
@kzinglzy kzinglzy deleted the fix-keepalive-doc branch March 20, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bai bai bai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kzinglzy @bai