Sets ConfigEntry.Default flag in addition to the ConfigEntry.Source for Kafka versions > V1_1_0_0 #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
… DescribeConfig This breaks the output of ListTopics for newer request versions, it now includes default configuration settings.
Clients can now rely on the `Default` flag again and don't have to check the `Source` for higher Kafka versions.
sladkoff
force-pushed
the
feature/fix-topic-config-default-flag
branch
from
51ba5d7
to
1b5e305
Compare
|
@sladkoff you might have to sign CLA. |
|
@varun06 yeah, I did that already... the check is still in a failed state and I can not re-submit the CLA form because it says that I already signed it... Can you help with that? Maybe reset something? |
|
I've re-run the CLA check, it's OK now |
bai
approved these changes
Feb 6, 2020
varun06
reviewed
Feb 9, 2020
|
Just letting you know that I've added some tests. Are we good here? |
dnwe
approved these changes
Feb 21, 2020
dnwe
changed the title
ronanh
pushed a commit
to ronanh/sarama
that referenced
this pull request
Mar 4, 2020
…or Kafka versions > V1_1_0_0 (IBM#1594) * Set describeConfigsRequest.Version in ListTopics for consistency with DescribeConfig This breaks the output of ListTopics for newer request versions, it now includes default configuration settings. * Set ConfigEntry.Default for KafkaVersions > 0 Clients can now rely on the `Default` flag again and don't have to check the `Source` for higher Kafka versions. * Set ConfigEntry.Source to default for KafkaVersions <= 0 when applicable * Add tests for default flag/source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were relying on the
ConfigEntry.Defaultfield to filter out any default config settings when usingadmin.DescribeConfig().After updating to the most recent version of sarama, this flag is always set to
falsewith Kafka versions >V1_1_0_0.We found out that we can now use the
ConfigEntry.Sourceto check for defaults. I don't know it was intended change to "break" theConfigEntry.Defaultin higher versions - let me know.This change sets the
ConfigEntry.Defaultflag in addition to theConfigEntry.Sourcefor Kafka versions >V1_1_0_0.I haven't written any tests yet as I'm not familiar with the code base. I can add some later.