add sync pool for gzip 1-9 #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun06
reviewed
Jan 18, 2020
| New: func() interface{} { | ||
| gz, err := gzip.NewWriterLevel(nil, 1) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
Not a big fan of panic, what happens if we reach here and panic?
There was a problem hiding this comment.
NewWriterLevel is like NewWriter but specifies the compression level instead of assuming DefaultCompression.
The compression level can be DefaultCompression, NoCompression, HuffmanOnly or any integer value between BestSpeed and BestCompression inclusive. The error returned will be nil if the level is valid.
1-9 level is correct.
There was a problem hiding this comment.
I am really not a big fan of using panic. but 👍
bai
approved these changes
Feb 22, 2020
varun06
approved these changes
Feb 23, 2020
sthagen
added a commit
to sthagen/Shopify-sarama
that referenced
this pull request
Feb 24, 2020
add sync pool for gzip 1-9 (IBM#1560)
ronanh
pushed a commit
to ronanh/sarama
that referenced
this pull request
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when large number of messages, for gzip(1-9) cost high cpu, because of gc.