From ae342e0bda3e57269f4b7296df078f6075ab2a24 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 5 Sep 2022 17:12:09 +0000 Subject: [PATCH 1/3] Bump rubocop from 1.35.1 to 1.36.0 Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.35.1 to 1.36.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.35.1...v1.36.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 344e1c04..5c32190f 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -27,7 +27,7 @@ GEM rake (13.0.6) regexp_parser (2.5.0) rexml (3.2.5) - rubocop (1.35.1) + rubocop (1.36.0) json (~> 2.3) parallel (~> 1.10) parser (>= 3.1.2.1) From 6c8269a2b4aa72a8088afead127dd630e910ef7f Mon Sep 17 00:00:00 2001 From: Sam Bostock Date: Tue, 6 Sep 2022 01:41:30 -0400 Subject: [PATCH 2/3] Dump updated config bundle exec rake config:dump --- test/fixtures/full_config.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/fixtures/full_config.yml b/test/fixtures/full_config.yml index 23c0acc6..af966ed9 100644 --- a/test/fixtures/full_config.yml +++ b/test/fixtures/full_config.yml @@ -2096,6 +2096,7 @@ Naming/MethodParameterName: MinNameLength: 3 AllowNamesEndingInNumbers: true AllowedNames: + - as - at - by - db @@ -2218,6 +2219,7 @@ Style/AccessModifierDeclarations: - inline - group AllowModifiersOnSymbols: true + SafeAutoCorrect: false Style/AccessorGrouping: Description: Checks for grouping of accessors in `class` and `module` bodies. Enabled: false @@ -2355,6 +2357,7 @@ Style/CaseEquality: VersionAdded: '0.9' VersionChanged: '0.89' AllowOnConstant: true + AllowOnSelfClass: false Style/CaseLikeIf: Description: Identifies places where `if-elsif` constructions can be replaced with `case-when`. From 9ea7d8f13b13b36902387d9f3269e153c66601e6 Mon Sep 17 00:00:00 2001 From: Sam Bostock Date: Tue, 6 Sep 2022 14:58:52 -0400 Subject: [PATCH 3/3] Enable Style/CaseEquality AllowOnSelfClass option --- rubocop.yml | 1 + test/fixtures/full_config.yml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/rubocop.yml b/rubocop.yml index 6582eab6..04b4d24c 100644 --- a/rubocop.yml +++ b/rubocop.yml @@ -390,6 +390,7 @@ Style/BisectedAttrAccessor: Style/CaseEquality: AllowOnConstant: true + AllowOnSelfClass: true Style/CaseLikeIf: Enabled: false diff --git a/test/fixtures/full_config.yml b/test/fixtures/full_config.yml index af966ed9..f679769e 100644 --- a/test/fixtures/full_config.yml +++ b/test/fixtures/full_config.yml @@ -2357,7 +2357,7 @@ Style/CaseEquality: VersionAdded: '0.9' VersionChanged: '0.89' AllowOnConstant: true - AllowOnSelfClass: false + AllowOnSelfClass: true Style/CaseLikeIf: Description: Identifies places where `if-elsif` constructions can be replaced with `case-when`.