Set Style/TrailingCommaInArguments's EnforcedStyleForMultiline to comma #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differently from the Hash and Array versions of this rule, this one uses the existence of parentheses to determine if a comma is needed or not, not if the method is multiline. As our style guide require parentheses for all method calls, so this rule can't use the consistent_comma option.
d1egoaz
approved these changes
Sep 13, 2022
| @@ -17,7 +17,7 @@ def test_config_is_unchanged | |||
| Rake::Task["config:dump"].invoke(tempfile.path) | |||
|
|
|||
| diff = Diffy::Diff.new( | |||
| original_config, tempfile.path, source: "files", context: 5, | |||
| original_config, tempfile.path, source: "files", context: 5 | |||
| ).to_s | |||
There was a problem hiding this comment.
What about also adding a test for where the ) is in the same line as the last item? that would have helped caching the issue with #432
diff = Diffy::Diff.new(
original_config, tempfile.path,
source: "files", context: 5).to_sThere was a problem hiding this comment.
This is a test for an unrelated thing that needed to change because of this rule, but we don't have tests for each rules in this repository. I usually do that with Shopify/shopify.
sambostock
approved these changes
Sep 13, 2022
|
We had it disabled. I think comma is the one that makes most sense if we are to enable it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differently from the Hash and Array versions of this rule, this one uses the existence of parentheses to determine if a comma is needed or not, not if the method is multiline. As our style guide require parentheses for all method calls, so this rule can't use the consistent_comma option.