Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.6.0 #388

Merged
merged 2 commits into from May 13, 2022
Merged

Release 2.6.0 #388

merged 2 commits into from May 13, 2022

Conversation

adrianna-chang-shopify
Copy link
Contributor

Release a new version so that consumers get the IgnoredPatterns => AllowedPatterns config rename.

Draft release here: https://github.com/Shopify/ruby-style-guide/releases/edit/untagged-048380b893a1794a3cfa

@sambostock
Copy link
Contributor

sambostock commented May 12, 2022

I think we might need to further bump the minimum required Rubocop version for the config to work. #386 bumped the Rubocop version in Gemfile.lock, and added various configs, but those configs won't exist in the older version of Rubocop.

I'm wondering if we can run CI against both locked version of Rubocop, and also against the oldest supported version, so we're sure it's compatible. 🤔

It's also worth nothing that if we do bump the requirement to 1.29, that version of Rubocop drops support for Ruby 2.5, if I recall correctly.

@sambostock
Copy link
Contributor

sambostock commented May 12, 2022

Yeah, as I suspected CI fails if we run it with the oldest Rubocop version.

So if we want to release one final version before dropping Ruby 2.5 support, we need to revert #386. Otherwise, we need to bump the minimum Rubocop version.

I have opened #389 to add CI checks for this and tentatively bump the minimum Rubocop version.

Copy link
Contributor

@sambostock sambostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should address the Rubocop version issue before releasing the next version. One way to do this would be to merge #389 first, if we're okay with springing a minimum Ruby version on our consumers.

@sambostock sambostock dismissed their stale review May 13, 2022 15:00

#389 has been merged, addressing my concerns. This will need a rebase though.

@rafaelfranca rafaelfranca merged commit 5f9071c into main May 13, 2022
@rafaelfranca rafaelfranca deleted the ac-release-2.6.0 branch May 13, 2022 18:10
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems May 13, 2022 19:59 Inactive
@adrianna-chang-shopify
Copy link
Contributor Author

Ah, failing to bump the rubocop version in the gemspec was a complete oversight on my part 🤦‍♀️ Thanks for tackling that @sambostock, and for going the extra mile and tightening up the CI pipeline ❤️ That will definitely help with preserving backwards compatibility for future rubocop version bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants