Skip to content

Update texts for refactor: extract variable #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

jenny-codes
Copy link
Contributor

Motivation

Addressing the two comments (this and this) from @andyw8 in #491 that I didn't get to before merging.

Implementation

Two text/copy changes:

  1. "Invalid selection for extract refactor" -> "Invalid selection for Extract Variable refactor"
  2. "Refactor: Extract variable" -> "Refactor: Extract Variable"

Automated Tests

No changes

Manual Tests

No changes

Verified

This commit was signed with the committer’s verified signature.
jenny-codes Jenny Shih
@jenny-codes jenny-codes self-assigned this Feb 21, 2023
@jenny-codes jenny-codes marked this pull request as ready for review February 21, 2023 18:42
@jenny-codes jenny-codes requested a review from a team as a code owner February 21, 2023 18:42
@github-actions
Copy link
Contributor

Benchmark results in seconds (slowest at top)

          textDocument/formatting average: 0.104504 std_dev: 0.027602
          textDocument/diagnostic average: 0.038526 std_dev: 0.001839
      textDocument/selectionRange average: 0.003804 std_dev: 0.000894
        textDocument/foldingRange average: 0.001613 std_dev: 7.0e-05
   textDocument/documentHighlight average: 0.001514 std_dev: 0.00016
 textDocument/semanticTokens/full average: 0.000829 std_dev: 0.000188
textDocument/semanticTokens/range average: 0.000626 std_dev: 4.9e-05
               textDocument/hover average: 0.0006 std_dev: 8.9e-05
        textDocument/documentLink average: 0.000538 std_dev: 4.4e-05
           textDocument/inlayHint average: 0.000416 std_dev: 4.0e-05
      textDocument/documentSymbol average: 0.000255 std_dev: 5.7e-05
    textDocument/onTypeFormatting average: 0.000111 std_dev: 8.4e-05
          textDocument/codeAction average: 3.1e-05 std_dev: 3.1e-05


================================================================================
Comparison with main branch:

 textDocument/semanticTokens/full unchanged
textDocument/semanticTokens/range unchanged
      textDocument/documentSymbol unchanged
        textDocument/foldingRange unchanged
          textDocument/formatting unchanged
          textDocument/diagnostic unchanged
        textDocument/documentLink unchanged
           textDocument/inlayHint unchanged
      textDocument/selectionRange unchanged
   textDocument/documentHighlight unchanged
               textDocument/hover unchanged
          textDocument/codeAction unchanged
    textDocument/onTypeFormatting unchanged

@jenny-codes jenny-codes merged commit a74e985 into main Feb 21, 2023
@jenny-codes jenny-codes deleted the update_refactor_extract_variable_texts branch February 21, 2023 19:27
@shopify-shipit shopify-shipit bot temporarily deployed to production February 22, 2023 15:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants