Skip to content

Add shutdown complete notice to logs #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

Add shutdown complete notice to logs #513

merged 1 commit into from
Feb 21, 2023

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Feb 21, 2023 •
edited
Loading

Motivation

Closes #508

Implementation

Automated Tests

n/a

Manual Tests

Stop the LSP, verify the message appears in the log.

@andyw8 andyw8 requested a review from a team as a code owner February 21, 2023 16:08
andyw8
andyw8 commented Feb 21, 2023
View reviewed changes
lib/ruby_lsp/server.rb
@@ -56,6 +56,7 @@ def start
# We return zero if shutdown has already been received or one otherwise as per the recommendation in the spec
# https://microsoft.github.io/language-server-protocol/specification/#exit
status = @store.empty? ? 0 : 1
warn("Shutdown complete with status #{status}")
Copy link
Contributor Author

@andyw8 andyw8 Feb 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it may be useful to include the status for if someone is sharing the logs.

@github-actions
Copy link
Contributor 

Benchmark results in seconds (slowest at top)

          textDocument/formatting average: 0.098464 std_dev: 0.026975
          textDocument/diagnostic average: 0.036111 std_dev: 0.001914
      textDocument/selectionRange average: 0.003595 std_dev: 0.000751
        textDocument/foldingRange average: 0.001595 std_dev: 0.0001
   textDocument/documentHighlight average: 0.001511 std_dev: 9.7e-05
 textDocument/semanticTokens/full average: 0.000794 std_dev: 0.000149
textDocument/semanticTokens/range average: 0.000604 std_dev: 1.6e-05
               textDocument/hover average: 0.000585 std_dev: 7.3e-05
        textDocument/documentLink average: 0.000524 std_dev: 3.4e-05
           textDocument/inlayHint average: 0.000407 std_dev: 3.1e-05
      textDocument/documentSymbol average: 0.000244 std_dev: 5.4e-05
    textDocument/onTypeFormatting average: 0.000106 std_dev: 6.5e-05
          textDocument/codeAction average: 3.0e-05 std_dev: 2.7e-05


================================================================================
Comparison with main branch:

 textDocument/semanticTokens/full unchanged
textDocument/semanticTokens/range unchanged
      textDocument/documentSymbol unchanged
        textDocument/foldingRange unchanged
          textDocument/formatting unchanged
          textDocument/diagnostic unchanged
        textDocument/documentLink unchanged
           textDocument/inlayHint unchanged
      textDocument/selectionRange unchanged
   textDocument/documentHighlight unchanged
               textDocument/hover unchanged
          textDocument/codeAction unchanged
    textDocument/onTypeFormatting unchanged

@andyw8 andyw8 merged commit b3d1201 into main Feb 21, 2023
@andyw8 andyw8 deleted the andyw8/add-shutdown-complete-notice-to-logs branch February 21, 2023 18:34
@shopify-shipit shopify-shipit bot temporarily deployed to production February 22, 2023 15:14 Inactive
vinistock pushed a commit that referenced this pull request Feb 28, 2024
@andyw8
Merge pull request #513 from Shopify/andyw8/detect-ruby-lsp-in-gemfil…
b2ae078 
…e-though-bundler

Detect `ruby-lsp` being in the `Gemfile` through `Bundler`
klaaspieter pushed a commit to klaaspieter/ruby-lsp that referenced this pull request Feb 25, 2025
@andyw8
Don't call check_all_pending! for older Rails (Shopify#513)
33da705 
Don't call check_all_pending! for older Rails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Improving the Ruby DX 2023 - Milestone 1
Development

Successfully merging this pull request may close these issues.

Indicate when Ruby LSP exit completes
3 participants
@andyw8 @vinistock @st0012