Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce parentheses around return values in signatures #190

Open
andyw8 opened this issue Oct 25, 2023 · 1 comment
Open

Enforce parentheses around return values in signatures #190

andyw8 opened this issue Oct 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@andyw8
Copy link
Contributor

andyw8 commented Oct 25, 2023

For consistency, we should have a cop to ensure that

sig { returns String }

is written as

sig { returns(String) }
@andyw8 andyw8 added the enhancement New feature or request label Oct 25, 2023
@andyw8
Copy link
Contributor Author

andyw8 commented Oct 25, 2023

Note: This only happens if Style/MethodCallWithArgsParentheses is configured as IgnoreMacros: false. I would say rubocop-shopify should take precedence over that for sigs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andyw8