Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorbet/ConstantsFromStrings does not catch &.constantize #140

Open
mrichman-flexe opened this issue Feb 15, 2023 · 0 comments
Open

Sorbet/ConstantsFromStrings does not catch &.constantize #140

mrichman-flexe opened this issue Feb 15, 2023 · 0 comments

Comments

@mrichman-flexe
Copy link

mrichman-flexe commented Feb 15, 2023 •
edited

The rule for ConstantsFromStrings does not catch null-safe usages. This appears to be due to the use of send instead of csend at line 38 of the the rule class.

https://github.com/Shopify/rubocop-sorbet/blob/main/lib/rubocop/cop/sorbet/constants_from_strings.rb#L38

Making this support catching the null safe variant would help make the rule more effective.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrichman-flexe