Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Release Builds Fail (RN 0.74+) #2430

Closed
enchorb opened this issue May 18, 2024 · 5 comments
Closed

Android Release Builds Fail (RN 0.74+) #2430

enchorb opened this issue May 18, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@enchorb
Copy link

enchorb commented May 18, 2024

Description

iOS is fine and Android debug builds are fine. Android release builds fail. (React Native 0.74.1)

Get the error [TypeError: undefined is not a function]

Commenting out the Canvas and all elements within it makes it not crash.

This was working fine on React Native 0.73.8 and Skia 0.1.229

Example provided below but I was also able to replicate with a single Canvas element on a screen also

Version

1.2.3

Steps to reproduce

Build release version of Android app

Snack, code example, screenshot, or link to a repository

@enchorb enchorb added the bug Something isn't working label May 18, 2024
@enchorb
Copy link
Author

enchorb commented May 18, 2024

More info: Is working fine on Android versions 11 (API 30) and below

Additional stack:

2024-05-17 22:24:40.995 24513-24622 ReactNativeJS           pid-24513                            E  [TypeError: undefined is not a function]
2024-05-17 22:24:40.996 24513-24623 unknown:ReactNative     pid-24513                            E  TypeError: undefined is not a function, js engine: hermes, stack:
                                                                                                    clearContainer@1:2869768
                                                                                                    Eg@1:2835736
                                                                                                    Th@1:2850621
                                                                                                    Nh@1:2850245
                                                                                                    Ch@1:2847149
                                                                                                    Xc@1:2806156
                                                                                                    J@1:2867011
                                                                                                    R@1:2867353
                                                                                                    anonymous@1:284808
                                                                                                    _callTimer@1:283759
                                                                                                    _callReactNativeMicrotasksPass@1:283903
                                                                                                    callReactNativeMicrotasks@1:285898
                                                                                                    __callReactNativeMicrotasks@1:147100
                                                                                                    anonymous@1:146184
                                                                                                    __guard@1:146938
                                                                                                    flushedQueue@1:146095
                                                                                                    callFunctionReturnFlushedQueue@1:145951

@enchorb
Copy link
Author

enchorb commented May 18, 2024

Upon even more testing and downgrading to React Native 0.73.8 (while keeping Skia at 1.2.3) the Android release builds work again. Seems to be some issue with 0.74+

@enchorb enchorb changed the title Android Release Builds Fail Android Release Builds Fail (RN 0.74+) May 18, 2024
@enchorb
Copy link
Author

enchorb commented May 24, 2024

@wcandillon any updates here? seems to be an issue with the react-reconciler and Skia in React Native 0.74+ in Android release builds API 31 and above

@wcandillon
Copy link
Collaborator

do you have a reproducible example? A project you could share on Github?

@enchorb
Copy link
Author

enchorb commented May 29, 2024

Issue found, seems to be coming from react-native-skottie

@enchorb enchorb closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants