Restrict Whitequark version to >= 2.6.4.0 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initializing the `Parser`, we call `emit_arg_inside_procarg0 = true` (https://github.com/Shopify/rbi/blob/main/lib/rbi/parser.rb#L25) but this method was added in v2.6.4.0 (whitequark/parser@17a66bd). With the wrong version of the `parser` gem, running Tapioca results in a stack trace: ``` vendor/bundle/ruby/2.6.0/gems/rbi-0.0.13/lib/rbi/parser.rb:28:in `<class:Parser>': undefined method `emit_arg_inside_procarg0=' for Parser::Builders::Default:Class (NoMethodError) Did you mean? emit_procarg0= from vendor/bundle/ruby/2.6.0/gems/rbi-0.0.13/lib/rbi/parser.rb:20:in `<module:RBI>' ``` Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com> Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
RyanBrushett
approved these changes
Mar 9, 2022
vinistock
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing the
Parser, we callemit_arg_inside_procarg0 = true(https://github.com/Shopify/rbi/blob/main/lib/rbi/parser.rb#L25) but this method was added in v2.6.4.0 (whitequark/parser@17a66bd).With the wrong version of the
parsergem, running Tapioca results in a stack trace: