Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade React to 18.3.1 and migrate act from react-dom/test-utils #2765

Closed
2 tasks done
peylun opened this issue Apr 29, 2024 · 0 comments
Closed
2 tasks done

Upgrade React to 18.3.1 and migrate act from react-dom/test-utils #2765

peylun opened this issue Apr 29, 2024 · 0 comments
Labels
Area: testing Package: react-testing Type: Enhancement 馃搱 Enhancement to our codebase

Comments

@peylun
Copy link

peylun commented Apr 29, 2024 •
edited

Overview

馃憢 We're from Shopify Audiences team and we have an dependabot upgrade (https://github.com/Shopify/shopify-audiences/pull/14918) that is possibly dependent on @shopify/react-testing to:

  • upgrade react and react-dom to v18.3.1 where act is exposed from react
  • migrate act from react-dom/test-utils to be imported from react (documentation)

Motivation

What inspired this enhancement? What makes you think this should be in quilt?

(Covered above)

Checklist

  • Please delete the labels section before submitting your issue
  • I have described this issue in a way that is actionable (if possible)
@brendo brendo mentioned this issue May 27, 2024
Merged
@brendo brendo closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: testing Package: react-testing Type: Enhancement 馃搱 Enhancement to our codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brendo @peylun