Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Badge] Add customAccessibilityLabel prop #4027

Closed
emma-boardman opened this issue Mar 2, 2021 · 2 comments
Closed

[Badge] Add customAccessibilityLabel prop #4027

emma-boardman opened this issue Mar 2, 2021 · 2 comments
Assignees
Labels
Accessibility Needs design, development, or content work relating to accessibility. Bug Something is broken and not working as intended in the system. no-issue-activity untriaged

Comments

@emma-boardman
Copy link
Contributor

emma-boardman commented Mar 2, 2021

Feature request summary

  • Allow a customAccessibilityLabel to be passed, overriding the default status/process accessibilityLabel

Rationale

The Online Store Editor currently uses the Polaris Badge to render the EditorStatusBadge.

image

The default <Badge/> accessibilityLabels match the progress and the status passed into the <Badge/>. For example, the live Editor badge will announce "Success Complete Live", which is potentially confusing.

Ideally, we would be able to pass a custom accessibilityLabel. For example, "Status: Live. Your online store is visible to customers".

PR

Experiment: #4028

Other approaches considered

  • Creating a custom component (https://github.com/Shopify/online-store-ui/pull/2528)
    • Drawbacks: We do want to stay aligned with the Polaris styles. Creating an entirely new (but very similar) component requires us to keep styles updated in both repos, and risks the styles diverging in the future.

🌟 Feature requests that are not yet planned will be closed. We then use the issue’s 👍 upvotes to track and set priorities. See the contribution guidelines for more information.

@emma-boardman emma-boardman self-assigned this Mar 2, 2021
@emma-boardman emma-boardman added the Accessibility Needs design, development, or content work relating to accessibility. label Mar 2, 2021
@alex-page alex-page removed the group 1 label Aug 19, 2022
@chloerice chloerice added Accessibility Needs design, development, or content work relating to accessibility. Bug Something is broken and not working as intended in the system. and removed Accessibility Needs design, development, or content work relating to accessibility. labels Aug 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's design system and dev experience.

@emma-boardman
Copy link
Contributor Author

Closed by #4028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Needs design, development, or content work relating to accessibility. Bug Something is broken and not working as intended in the system. no-issue-activity untriaged
Projects
None yet
Development

No branches or pull requests

4 participants