Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextStyle] Fix an issue where inline code would be hard to select #4005

Merged
merged 1 commit into from Feb 17, 2021
Merged

[TextStyle] Fix an issue where inline code would be hard to select #4005

merged 1 commit into from Feb 17, 2021

Conversation

kaelig
Copy link
Contributor

@kaelig kaelig commented Feb 17, 2021 •
edited

WHY are these changes introduced?

The ::after pseudo element goes on top of the code, making it impossible to select when clicking/selecting or double clicking on it.

WHAT is this pull request doing?

It adds pointer-events: none to the pseudo element that covers the code, so that clicking on code isn't impacted by it.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2021 •
edited

🟡 This pull request modifies 2 files and might impact 63 other files. This is an average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 63)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/TextStyle/TextStyle.scss (total: 63)

Files potentially affected (total: 63)

kyledurand
kyledurand approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kaelig kaelig merged commit 6864ea5 into main Feb 17, 2021
@kaelig kaelig deleted the fix-selectable-code branch February 17, 2021 23:39
This was referenced Mar 18, 2021
Closed
Closed
sylvhama pushed a commit that referenced this pull request Mar 26, 2021
@kaelig @sylvhama
[TextStyle] Fix an issue where inline code would be hard to select (#…
75a94e7 
…4005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyledurand kyledurand kyledurand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaelig @kyledurand