[Modal, Frame(Nav), Sheet] Trapped virtual cursor inside dialogs #3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
馃煛 This pull request modifies 7 files and might impact 5 other files. This is an average splash zone for a change, remember to tophat areas that could be affected. Details:All files potentially affected (total: 5)馃搫
|
AndrewMusgrave
force-pushed
the
virtual-cursor-trap-focus
branch
from
17873a3
to
815560a
Compare
AndrewMusgrave
force-pushed
the
virtual-cursor-trap-focus
branch
from
815560a
to
5cf863a
Compare
kyledurand
approved these changes
Jan 28, 2021
kyledurand
approved these changes
Jan 29, 2021
This was referenced Mar 18, 2021
sylvhama
pushed a commit
that referenced
this pull request
Mar 26, 2021
* Trapped virtual cursor inside dialogs * changelog * Add nav container label * Only applt attributes on small screens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Keyboard focus is trapped whoever virtual cursors are not
Current keyboard trapping
Before/After virtual cursor navigation
WHAT is this pull request doing?
How to 馃帺