Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IndexTable] Align IndexTable checkbox header with other headers #3990

Merged
merged 4 commits into from Feb 11, 2021

Conversation

lhoffbeck
Copy link
Contributor

WHY are these changes introduced?

Fixes #3989

On the IndexTable component, the select all checkbox isn't vertically centered with the rest of the the table headers. This is due to the checkbox having a display: inline-flex;, which adds whitespace since it's an inline element. This stackoverflow answer does a good job summarizing the issue.

WHAT is this pull request doing?

This PR adds a wrapper around the checkbox header to fix the alignment.

馃憖 BEFORE 馃憖

IndexTable / Simple Index Table example
Screen Shot 2021-02-10 at 5 07 51 PM

IndexTable / Simple Index Table example w/sticky headers
Screen Shot 2021-02-10 at 5 14 00 PM

馃憖 AFTER 馃憖
IndexTable / Simple Index Table example w/sticky headers
Screen Shot 2021-02-10 at 5 06 56 PM

IndexTable / Simple Index Table example
Screen Shot 2021-02-10 at 5 13 48 PM

馃帺 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @鈥奌YPD, @鈥妋irualves, @鈥妔arahill, or @鈥妑y5n to update the Polaris UI kit

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2021

馃煝 This pull request modifies 3 files and might impact 1 other files.

Details:
All files potentially affected (total: 1)
馃搫 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

馃帹 src/components/IndexTable/IndexTable.scss (total: 1)

Files potentially affected (total: 1)

馃З src/components/IndexTable/IndexTable.tsx (total: 0)

Files potentially affected (total: 0)

Copy link
Member

@AndrewMusgrave AndrewMusgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 馃挴 I didn't previously notice it was off, but now I see the screenshot it's all I see 馃槀 I just approved percy so you're fully green now

UNRELEASED.md Outdated Show resolved Hide resolved
@lhoffbeck lhoffbeck merged commit ba6cc73 into main Feb 11, 2021
@lhoffbeck lhoffbeck deleted the 3989-fix-indextable-checkbox-alignment branch February 11, 2021 21:23
sylvhama pushed a commit that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IndexTable] Checkbox is misaligned with other table headers
2 participants