Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen only on localhost by default #14

Open
sandstrom opened this issue Oct 12, 2022 · 1 comment
Open

Listen only on localhost by default #14

sandstrom opened this issue Oct 12, 2022 · 1 comment

Comments

@sandstrom
Copy link

Awesome project! 馃弲

From the README:

pitchfork will bind to all interfaces on TCP port 8080 by default.

Since a --listen flag already exist, I'd suggest binding only to localhost (127.0.0.1) by default.

I know this is mostly used internally right now, but it's such a common thing for webservers to accidentally bind to a public interface, for example on developer machines, unknowingly exposing an app to the internet.

@byroot
Copy link
Contributor

byroot commented Oct 13, 2022

Thank you, that's a good point.

This default is inherited from unicorn, but I agree we should reconsider it. I'll have a look next week.

@sandstrom sandstrom changed the title Listen only on local host by default Listen only on localhost by default Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants