Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorbet type signatures #262

Open
olivier-thatch opened this issue Apr 19, 2023 · 0 comments
Open

Sorbet type signatures #262

olivier-thatch opened this issue Apr 19, 2023 · 0 comments
Labels

Comments

@olivier-thatch
Copy link

Some weeks ago I submitted Sorbet type signatures for the money gem to the rbi-central repo (PR).

Would you consider adding type signatures directly in the gem?

To clarify: this would mean adding RBI files with the signatures in an rbi/ directory distributed as part of the gem (cf. Sorbet docs), not adding a dependency on sorbet-runtime or adding the signatures inline with their methods. Non-Sorbet users would not be affected.

If you're open to this, I will submit a PR.

@elfassy elfassy added the todo label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants