Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review information in currency_iso.json to ensure it's accurate #143

Open
clauderic opened this issue Jan 31, 2018 · 1 comment
Open

Review information in currency_iso.json to ensure it's accurate #143

clauderic opened this issue Jan 31, 2018 · 1 comment
Milestone

Comments

@clauderic
Copy link
Member

clauderic commented Jan 31, 2018

It looks like certain currencies listed in currency_iso.json have inaccurate values, specifically, some currencies are listed as having subunit_to_unit: 1, yet also have a non-null decimal_mark 🤔

Similarly, there seems to be some discrepancy between what character the browser's Number.toLocaleString API returns for certain locales, for instance, for be-BY, the thousands separator is ,, whereas it's listed in currency_iso.json as

(1235.50).toLocaleString("be-BY", {currency: 'BYR', style: 'currency', currencyDisplay: 'symbol'})
// "BYR 1,236"

However, looking at the data for the Intl.js polyfill, it looks like the thousands separator is listed as , https://github.com/andyearnshaw/Intl.js/blob/master/locale-data/json/be-BY.json#L285 so I'm
not sure which is accurate 🤷‍♂️

@bdewater
Copy link
Contributor

I'm pretty sure it's not. AFAIK the browser/OS data is from https://www.currency-iso.org/en/home/tables.html or https://www.unicode.org/repos/cldr/trunk/common/supplemental/supplementalData.xml (which uses the former as a basis)

@bdewater bdewater added this to the v1.0.0 milestone Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants