Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape_once doesn't ignore hexadecimal entities #792

Closed
kainjow opened this issue Aug 26, 2016 · 1 comment · May be fixed by #1788
Closed

escape_once doesn't ignore hexadecimal entities #792

kainjow opened this issue Aug 26, 2016 · 1 comment · May be fixed by #1788

Comments

@kainjow
Copy link
Contributor

kainjow commented Aug 26, 2016 

{{ "! ! !" | escape_once }}

Outputs:

! ! !

https://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references
https://dev.w3.org/html5/html-author/charref
@kainjow
Copy link
Contributor Author

kainjow commented Aug 26, 2016

Entities with letters and numbers don't work either:

{{ "¾ ¾ ¾" | escape_once }}

Outputs:

¾ ¾ ¾

@kainjow kainjow mentioned this issue Aug 28, 2016
Closed
@kainjow kainjow closed this as completed Aug 28, 2016
@kainjow kainjow mentioned this issue Aug 31, 2016
Closed
cr7pt0gr4ph7 pushed a commit to cr7pt0gr4ph7/liquid that referenced this issue Feb 22, 2024
Fix handling of hexadecimal escapes in escape_once
697c1ec 
This also aligns the behavior once again with current behavior of
ActionView::Helpers::TagHelper#escape_once / ERB::Util::html_escape_once,
which escape_once was originally based on.

Fixes Shopify#792
@cr7pt0gr4ph7 cr7pt0gr4ph7 mentioned this issue Feb 22, 2024
Open
cr7pt0gr4ph7 added a commit to cr7pt0gr4ph7/liquid that referenced this issue Feb 22, 2024
@cr7pt0gr4ph7
Fix handling of hexadecimal escapes in escape_once
8ad8b43 
This also aligns the behavior once again with current behavior of
ActionView::Helpers::TagHelper#escape_once / ERB::Util::html_escape_once,
which escape_once was originally based on.

Fixes Shopify#792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of hexadecimal escapes in escape_once cr7pt0gr4ph7/liquid
1 participant
@kainjow