Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font_url displays error with preload_tag due to whitelist #1768

Closed
skooch opened this issue Dec 10, 2023 · 3 comments
Closed

font_url displays error with preload_tag due to whitelist #1768

skooch opened this issue Dec 10, 2023 · 3 comments

Comments

@skooch
Copy link

skooch commented Dec 10, 2023

Hey, i'm having this issue with

{{ settings.type_body_font | font_url | preload_tag: as: 'font', type: 'font/woff2', crossorigin: 'anonymous' }}

and getting the Liquid error

Input must be a theme or shop asset URL.

Related: #1738

@skooch skooch changed the title font_url does not work with preload_tag due to whitelist font_url displays error with preload_tag due to whitelist Dec 10, 2023
@skooch
Copy link
Author

skooch commented Dec 10, 2023

settings.type_body_font is a Shopify Font, example:

//<shopify>/cdn/fonts/rockwell/rockwell_n7.d323c91936400f00c1acd51d95a6cdaa9a98f8db.woff2

@skooch
Copy link
Author

skooch commented Apr 7, 2024

@ianks @ggmichaelgo Hey team 👋 would you happen to know why many issues and pull requests are going without triage on this repository? Is it in maintenance mode? Should I be escalating the issues I'm experiencing through Shopify support?

Just feeling a bit lost here!

@ggmichaelgo
Copy link
Contributor

Hello @skooch !
I apologize for the late reply on your issue 🙏
The font_url is not a filter from the Liquid gem; it is a custom Liquid filter from Shopify.
There are many other filters that are only available through Shopify Themes. (Shopify Liquid Doc / Font URL doc)

For Shopify Theme development issues, it is best to reach out to the Shopify support team.
The Liquid repo's Github Issue shouldn't be used for Shopify theme development supports since it is dedicated to the core functionality and development of the Liquid gem itself.

Thank you for your understanding and cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants