add severity level support for all linters #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domingo2000
force-pushed
the
add-severity-level-for-all-linters
branch
4 times, most recently
from
a2fa4cb
to
7c37134
Compare
|
@etiennebarrie Could you help with the revision here? |
|
Can you add information about the feature in the README? |
domingo2000
force-pushed
the
add-severity-level-for-all-linters
branch
from
7c37134
to
e3cda2b
Compare
|
@etiennebarrie Done! I created a section of the severity configuration in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #348.
Introduce a severity level of
:errorby default to all the linters that does not have a configured severity level. Introducing a new severity level property in the linter configuration we achieve that now all the linters can have aseverityproperty in the.erb-lint.yml.Because currently the linter already has support for some compatibility with the severity levels of rubocop, this change only extends the same behaviour but for all linters.
This permits for example to omit the errors of
MyCustomLinterwhen runningerblint foo.erbwith the following configurationThis is useful to introduce linters in a codebease in an incremental manner, to configure to not throw errors when introducing a linter but still seeing it in the editor, for example when running the linter in CI.