Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors during rubocop linting should return non-zero exit code #290

Open
oehlschl opened this issue Nov 10, 2022 · 0 comments
Open

Errors during rubocop linting should return non-zero exit code #290

oehlschl opened this issue Nov 10, 2022 · 0 comments

Comments

@oehlschl
Copy link

Filing this after #286, in which we didn't notice a breaking rubocop upgrade in our CI because erblint returns a 0 exit code in the case that the rubocop linter fails in error.

It looks like this could be solved by either:

  • updating the rubocop linter to be aware of .errors in addition to .offenses
  • instantiating the rubocop Team with the raise_cop_error option

The latter works as expected and prints a backtrace (it gets caught by this line), though the output isn't particularly pretty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant