Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Block Missing Data On Theme Previews When Proceeded by a Hidden Section Containing an @app Block #3413

Open
kevin-aminzadeh opened this issue Apr 11, 2024 · 0 comments

Comments

@kevin-aminzadeh
Copy link

kevin-aminzadeh commented Apr 11, 2024

Describe the current behavior

When a theme section containing our app block/theme extension is placed directly after a hidden section which contains an app block, liquid data is not correctly passed to our app block.

Describe the expected behavior

Block liquid data should be available to the app block regardless of block/section order and customiser "visibility" status

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 13.0.1
  • Chrome Version 108.0.5359.124
  • macOS Version 13.1

Possible solution

This appears to be a bug in the Shopify liquid parser and specifically impacts offline/preview themes so possible solutions are unclear

Additional context/screenshots

shopify-app-block-bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant