Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme][Enhancement] Review ergonomics of theme selection flags in the push command #3801

Open
jamesmengo opened this issue Apr 26, 2024 · 0 comments
Labels
Area: @shopify/theme @shopify/theme package issues tech debt Liquid SF (tech debt)

Comments

@jamesmengo
Copy link
Contributor

          The entire treatment of the `-u` `-d`, `--live`, and `-t` flags are pretty smelly imo
  • -u, -d, and --live represent the role of the theme, so I feel like the combination of these two flags can make usage confusing. Should combining theme push to ALL of those themes?
    - My initial thought is that it should create 3 themes OR we need to specify the precedence of these flags in the docs
  • the -t flag changes meaning when you provide it in combination with -u and -d
    • theme push -t themename searches for a theme with the name themename and fails if it doesn't exist
    • theme push -u -t themename will create a theme with the name themename even if one already exists

This pr is not the place to apply these changes (in fact, it's kind of difficult to change the semantics of these flags without careful consideration), but I think the ergonomics of these flags can be fleshed out a little more :)

Originally posted by @jamesmengo in #3798 (comment)

@jamesmengo jamesmengo added Area: @shopify/theme @shopify/theme package issues tech debt Liquid SF (tech debt) labels Apr 26, 2024
@jamesmengo jamesmengo changed the title [Theme][Enhancement] Ergonomics of theme selection flags in the push command [Theme][Enhancement] Review ergonomics of theme selection flags in the push command Apr 26, 2024
@jamesmengo jamesmengo added Area: @shopify/cli @shopify/cli package issues and removed Area: @shopify/cli @shopify/cli package issues labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues tech debt Liquid SF (tech debt)
Projects
None yet
Development

No branches or pull requests

1 participant