Remove extraneous memory allocations in C #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ext/bootsnap/bootsnap.c
Outdated
Comment on lines
715
to
716
| input_data = rb_str_buf_new(cached_key.size); | ||
| if (bs_read_contents(current_fd, current_key.size, input_data, &errno_provenance) < 0) goto fail_errno; |
There was a problem hiding this comment.
Since the return value of bs_read_contents is always checked against < 0, you could move rb_str_buf_new inside, and return Qfalse on failure.
There was a problem hiding this comment.
Ok, made those adjustments in d1c01f6
casperisfine
approved these changes
Mar 14, 2023
|
Should I handle changelog / merging? |
|
Thanks. No need for a changelog entry, this is a minor optimization without any behavior change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of
rb_str_buf_new, so we canreaddirectly into it. This avoids an an extraneousALLOC_Nand correspondingxfreefor every item that is read.