Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README.md's setup example typo: "ignored_directories" #426

Merged
merged 1 commit into from Nov 18, 2022
Merged

Fix README.md's setup example typo: "ignored_directories" #426

merged 1 commit into from Nov 18, 2022

Conversation

ansonhoyt
Copy link
Contributor

@ansonhoyt ansonhoyt commented Nov 18, 2022 •
edited

Fix missing : and misspelt argument. Makes this example work.

Introduced by #424

@ansonhoyt
Update README.md
8471a67 
Fix missing `:` and misspelt argument. Makes this example work.
@ansonhoyt
Copy link
Contributor Author

ansonhoyt commented Nov 18, 2022 •
edited

Hmmm, cla-needed label but CONTRIBUTING.md makes no mention of a CLA. I Googled and completed https://cla.shopify.com/individual-cla, but maybe the guide should mention it?

Edit: ah, the check explains it!

@casperisfine casperisfine merged commit 8f519cb into Shopify:main Nov 18, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems November 20, 2022 04:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ansonhoyt @casperisfine