Simplified handling of UTF-8 symbols in YAML #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We actually don't need to store the encoding, we can assume everything is UTF-8. `Symbol#to_sym` will take care of coercing to ASCII when applicable. Any other encoding is not supported as the cache should be invoked if Psych could generate any other encoding.
casperisfine
force-pushed
the
simpler-symbol-encoding
branch
from
fc94fc4
to
85f1242
Compare
| @@ -2,7 +2,7 @@ | |||
| * Suggested reading order: | |||
| * 1. Skim Init_bootsnap | |||
| * 2. Skim bs_fetch | |||
| * 3. The rest of everything | |||
| * 3. The rest of everyrything | |||
There was a problem hiding this comment.
I presume this was typed by accident: everything?
teoljungberg
added a commit
to teoljungberg/bootsnap
that referenced
this pull request
Feb 16, 2022
The typo was introduced by accident in Shopify#399.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually don't need to store the encoding, we can assume
everything is UTF-8.
Symbol#to_symwill take care of coercingto ASCII when applicable.
Any other encoding is not supported as the cache should be invoked
if Psych could generate any other encoding.