psych < 4 fix #369
Merged
psych < 4 fix #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
🤦 . Thank you! |
texpert
added a commit
to texpert/florsan
that referenced
this pull request
Aug 27, 2021
texpert
added a commit
to texpert/rails_6_rss_reader
that referenced
this pull request
Aug 27, 2021
gsmendoza
added a commit
to solidusio/solidus_starter_frontend
that referenced
this pull request
Aug 31, 2021
Currently getting the following error with bootsnap 1.8.0:
```
Failures:
1) Sign In show validation erros
Failure/Error: visit spree.login_path
I18n::InvalidLocaleData:
can not load translations from /home/gsmendoza/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/bundler/gems/solidus_i18n-502e467babda/config/locales/cs.yml: #<NoMethodError: undefined method `unsafe_load' for Psych:Module
Did you mean? safe_load>
# ./spec/system/authentication/sign_in_spec.rb:8:in `block (2 levels) in <main>'
# ------------------
# --- Caused by: ---
# NoMethodError:
# undefined method `unsafe_load' for Psych:Module
# Did you mean? safe_load
# ./spec/system/authentication/sign_in_spec.rb:8:in `block (2 levels) in <main>'
Finished in 1.86 seconds (files took 1.51 seconds to load)
1 example, 1 failure
Failed examples:
rspec ./spec/system/authentication/sign_in_spec.rb:22 # Sign In show validation erros
```
The bootsnap issue was introduced in
Shopify/bootsnap@1d14e25.
This an open PR fixing it: Shopify/bootsnap#369.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 28, 2022
Psych unsafe_load was added for psych 4 / 3 compatibility but was only available in 3.3.2 and newer. Prior to this change, bootsnap 1.8.0 would be break on psych 3.3.1 and older. Bootsnap added psych 4 compatibility in 1.8.0 by using unsafe_load but this doesn't work with 3.3.1 or older: Shopify/bootsnap#368 Bootnap 1.8.1 allows older versions of psych to be compatible via: Shopify/bootsnap#369
GilbertCherrie
pushed a commit
to GilbertCherrie/manageiq
that referenced
this pull request
Jul 7, 2023
Psych unsafe_load was added for psych 4 / 3 compatibility but was only available in 3.3.2 and newer. Prior to this change, bootsnap 1.8.0 would be break on psych 3.3.1 and older. Bootsnap added psych 4 compatibility in 1.8.0 by using unsafe_load but this doesn't work with 3.3.1 or older: Shopify/bootsnap#368 Bootnap 1.8.1 allows older versions of psych to be compatible via: Shopify/bootsnap#369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsafe_loaddoesn't exist on older versions #368fixes