Fix Psych 4 compatibility and add caching for YAML.unsafe_load_file #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psych 4 now load in safe mode by default, which means many features such as aliases are disabled by default. This makes it complicated for Bootsnap to cache, and pretty much impossible to precompile. So until we figure out a better solution, we're better to entirely disable that cache for Psych 4+. However it can stay active for `YAML.unsafe_load_file`.
Merged
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 28, 2022
Psych unsafe_load was added for psych 4 / 3 compatibility but was only available in 3.3.2 and newer. Prior to this change, bootsnap 1.8.0 would be break on psych 3.3.1 and older. Bootsnap added psych 4 compatibility in 1.8.0 by using unsafe_load but this doesn't work with 3.3.1 or older: Shopify/bootsnap#368 Bootnap 1.8.1 allows older versions of psych to be compatible via: Shopify/bootsnap#369
GilbertCherrie
pushed a commit
to GilbertCherrie/manageiq
that referenced
this pull request
Jul 7, 2023
Psych unsafe_load was added for psych 4 / 3 compatibility but was only available in 3.3.2 and newer. Prior to this change, bootsnap 1.8.0 would be break on psych 3.3.1 and older. Bootsnap added psych 4 compatibility in 1.8.0 by using unsafe_load but this doesn't work with 3.3.1 or older: Shopify/bootsnap#368 Bootnap 1.8.1 allows older versions of psych to be compatible via: Shopify/bootsnap#369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Psych 4 now load in safe mode by default, which means many
features such as aliases are disabled by default.
This makes it complicated for Bootsnap to cache, and pretty
much impossible to precompile.
So until we figure out a better solution, we're better to
entirely disable that cache for Psych 4+. However it
can stay active for
YAML.unsafe_load_file.