Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Compile Cache C Error #356

Closed
metaskills opened this issue Apr 24, 2021 · 5 comments
Closed

Disable Compile Cache C Error #356

metaskills opened this issue Apr 24, 2021 · 5 comments

Comments

@metaskills
Copy link
Contributor

While working on #355 I was exploring setting the DISABLE_BOOTSNAP_COMPILE_CACHE to see how only the load path optimizations might work. When doing this, I get the following error.

undefined method `instrumentation_enabled=' for Bootsnap:Module\nDid you mean?  instrumentation=
Init<NoMethodError>
"/var/task/vendor/bundle/ruby/2.7.0/gems/bootsnap-1.7.4/lib/bootsnap.rb:30:in `instrumentation='",
"/var/task/vendor/bundle/ruby/2.7.0/gems/bootsnap-1.7.4/lib/bootsnap.rb:24:in `logger='",
"/var/task/vendor/bundle/ruby/2.7.0/gems/bootsnap-1.7.4/lib/bootsnap.rb:16:in `log!'",
"/var/task/vendor/bundle/ruby/2.7.0/gems/bootsnap-1.7.4/lib/bootsnap.rb:117:in `default_setup'",
"/var/task/vendor/bundle/ruby/2.7.0/gems/bootsnap-1.7.4/lib/bootsnap/setup.rb:4:in `<top (required)>'",
"/var/task/app.rb:14:in `require'",
"/var/task/app.rb:14:in `<top (required)>'",
"/var/lang/lib/ruby/site_ruby/2.7.0/rubygems/core_ext/kernel_require.rb:85:in `require'",
"/var/lang/lib/ruby/site_ruby/2.7.0/rubygems/core_ext/kernel_require.rb:85:in `require'"
@metaskills
Copy link
Contributor Author

Seems I can call require 'bootsnap/bootsnap' prior to setup and avoid this. Might make the case this require should be higher up somewhere?

@casperisfine
Copy link
Contributor

It seems you need BOOTSNAP_LOG=1 as well to trigger this. It's because the logging method didn't account for bootsnap to be mostly disabled. I'll fix this directly on master. Thanks for the report.

@metaskills
Copy link
Contributor Author

It seems you need BOOTSNAP_LOG=1 as well to trigger this.

Correct! I was using that. Think this is worth a v1.7.5 release?

@casperisfine
Copy link
Contributor

Think this is worth a v1.7.5 release?

Honestly I don't think so. It's kind of a rare use case of wanting to both disable bootsnap but log it.

@metaskills
Copy link
Contributor Author

Cool, I'll wait for a release till I pull my patches out. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants