YAML cache: do not cache documents containing tags #351
+44
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmreid
approved these changes
Mar 19, 2021
casperisfine
force-pushed
the
psych-tags
branch
from
7ec692c
to
9cc3f83
Compare
casperisfine
force-pushed
the
psych-tags
branch
from
9cc3f83
to
aa9b800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Psych behavior is a bit weird, when it encounter a tag it doesn't know about, it just ignores it, e.g.:
So if an app do end up defining custom tags, the YAML pre-compilation might cache an incorrect version of the document.