Update input_to_output method arguments to use dissimilar names #333
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method using `_` for both arguments was causing Sorbet to fail when generating type information (sorbet/sorbet#3561). This change doesn't modify any functionality or outward API in the gem itself. The argument names are based on the arguments for input_to_output in `lib/bootsnap/compile_cache/yaml.rb`.
ghost
added
the
|
I'm not sure how to get the CLA job to restart but I have signed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method using
_for both arguments was causing Sorbet to fail when generating type information (sorbet/sorbet#3561). This change doesn't modify any functionality or outward API in the gem itself. The argument names are based on the arguments forinput_to_outputinlib/bootsnap/compile_cache/yaml.rb.