Refactor PathScanner to avoid Dir.glob #312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main concern with
Dir.glob
is that it becomes sorted by default in2.8/3.0
which makes it quite slower for large result sets. That can easily be fixed by passingsort: false
, but while I was at it I figured there might be ways to avoid the cost of allocating and returning giant arrays.So instead I use
foreach
which yield directory entries one by one.I benched it against large directories and it's noticeably faster: https://gist.github.com/casperisfine/68819290350f8036d48a1d71777d5616