/
casecmp_spec.rb
198 lines (162 loc) · 6.58 KB
/
casecmp_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Performance::Casecmp do
subject(:cop) { described_class.new }
shared_examples 'selectors' do |selector|
it "registers an offense and corrects str.#{selector} ==" do
expect_offense(<<~RUBY, selector: selector)
str.#{selector} == 'string'
^^^^^{selector}^^^^^^^^^^^^ Use `str.casecmp('string').zero?` instead of `str.#{selector} == 'string'`.
RUBY
expect_correction(<<~RUBY)
str.casecmp('string').zero?
RUBY
end
it "registers an offense and corrects str.#{selector} == with parens around arg" do
expect_offense(<<~RUBY, selector: selector)
str.#{selector} == ('string')
^^^^^{selector}^^^^^^^^^^^^^^ Use `str.casecmp('string').zero?` instead of `str.#{selector} == ('string')`.
RUBY
expect_correction(<<~RUBY)
str.casecmp('string').zero?
RUBY
end
it "registers an offense and corrects str.#{selector} !=" do
expect_offense(<<~RUBY, selector: selector)
str.#{selector} != 'string'
^^^^^{selector}^^^^^^^^^^^^ Use `str.casecmp('string').zero?` instead of `str.#{selector} != 'string'`.
RUBY
expect_correction(<<~RUBY)
!str.casecmp('string').zero?
RUBY
end
it "registers an offense and corrects str.#{selector} != with parens around arg" do
expect_offense(<<~RUBY, selector: selector)
str.#{selector} != ('string')
^^^^^{selector}^^^^^^^^^^^^^^ Use `str.casecmp('string').zero?` instead of `str.#{selector} != ('string')`.
RUBY
expect_correction(<<~RUBY)
!str.casecmp('string').zero?
RUBY
end
it "registers an offense and corrects str.#{selector}.eql? without parens" do
expect_offense(<<~RUBY, selector: selector)
str.#{selector}.eql? 'string'
^^^^^{selector}^^^^^^^^^^^^^^ Use `str.casecmp('string').zero?` instead of `str.#{selector}.eql? 'string'`.
RUBY
expect_correction(<<~RUBY)
str.casecmp('string').zero?
RUBY
end
it "registers an offense and corrects str.#{selector}.eql? with parens" do
expect_offense(<<~RUBY, selector: selector)
str.#{selector}.eql?('string')
^^^^^{selector}^^^^^^^^^^^^^^^ Use `str.casecmp('string').zero?` instead of `str.#{selector}.eql?('string')`.
RUBY
expect_correction(<<~RUBY)
str.casecmp('string').zero?
RUBY
end
it "registers an offense and corrects str.#{selector}.eql? with parens and funny spacing" do
expect_offense(<<~RUBY, selector: selector)
str.#{selector}.eql? ( 'string' )
^^^^^{selector}^^^^^^^^^^^^^^^^^^ Use `str.casecmp( 'string' ).zero?` instead of `str.#{selector}.eql? ( 'string' )`.
RUBY
expect_correction(<<~RUBY)
str.casecmp( 'string' ).zero?
RUBY
end
it "registers an offense and corrects == str.#{selector}" do
expect_offense(<<~RUBY, selector: selector)
'string' == str.#{selector}
^^^^^^^^^^^^^^^^^{selector} Use `str.casecmp('string').zero?` instead of `'string' == str.#{selector}`.
RUBY
expect_correction(<<~RUBY)
str.casecmp('string').zero?
RUBY
end
it "registers an offense and corrects string with parens == str.#{selector}" do
expect_offense(<<~RUBY, selector: selector)
('string') == str.#{selector}
^^^^^^^^^^^^^^^^^^^{selector} Use `str.casecmp('string').zero?` instead of `('string') == str.#{selector}`.
RUBY
expect_correction(<<~RUBY)
str.casecmp('string').zero?
RUBY
end
it "registers an offense and corrects string != str.#{selector}" do
expect_offense(<<~RUBY, selector: selector)
'string' != str.#{selector}
^^^^^^^^^^^^^^^^^{selector} Use `str.casecmp('string').zero?` instead of `'string' != str.#{selector}`.
RUBY
expect_correction(<<~RUBY)
!str.casecmp('string').zero?
RUBY
end
it 'registers an offense and corrects string with parens and funny spacing ' \
"eql? str.#{selector}" do
expect_offense(<<~RUBY, selector: selector)
( 'string' ).eql? str.#{selector}
^^^^^^^^^^^^^^^^^^^^^^^{selector} Use `str.casecmp( 'string' ).zero?` instead of `( 'string' ).eql? str.#{selector}`.
RUBY
expect_correction(<<~RUBY)
str.casecmp( 'string' ).zero?
RUBY
end
it "registers an offense and corrects string.eql? str.#{selector} without parens " do
expect_offense(<<~RUBY, selector: selector)
'string'.eql? str.#{selector}
^^^^^^^^^^^^^^^^^^^{selector} Use `str.casecmp('string').zero?` instead of `'string'.eql? str.#{selector}`.
RUBY
expect_correction(<<~RUBY)
str.casecmp('string').zero?
RUBY
end
it "registers an offense and corrects string.eql? str.#{selector} with parens " do
expect_offense(<<~RUBY, selector: selector)
'string'.eql?(str.#{selector})
^^^^^^^^^^^^^^^^^^^{selector}^ Use `str.casecmp('string').zero?` instead of `'string'.eql?(str.#{selector})`.
RUBY
expect_correction(<<~RUBY)
str.casecmp('string').zero?
RUBY
end
it "registers an offense and corrects obj.#{selector} == str.#{selector}" do
expect_offense(<<~RUBY, selector: selector)
obj.#{selector} == str.#{selector}
^^^^^{selector}^^^^^^^^^{selector} Use `obj.casecmp(str).zero?` instead of `obj.#{selector} == str.#{selector}`.
RUBY
expect_correction(<<~RUBY)
obj.casecmp(str).zero?
RUBY
end
it "registers an offense and corrects obj.#{selector} eql? str.#{selector}" do
expect_offense(<<~RUBY, selector: selector)
obj.#{selector}.eql? str.#{selector}
^^^^^{selector}^^^^^^^^^^^{selector} Use `obj.casecmp(str).zero?` instead of `obj.#{selector}.eql? str.#{selector}`.
RUBY
expect_correction(<<~RUBY)
obj.casecmp(str).zero?
RUBY
end
it "doesn't report an offense for variable == str.#{selector}" do
expect_no_offenses(<<~RUBY)
var = "a"
var == str.#{selector}
RUBY
end
it "doesn't report an offense for str.#{selector} == variable" do
expect_no_offenses(<<~RUBY)
var = "a"
str.#{selector} == var
RUBY
end
it "doesn't report an offense for obj.method == str.#{selector}" do
expect_no_offenses("obj.method == str.#{selector}")
end
it "doesn't report an offense for str.#{selector} == obj.method" do
expect_no_offenses("str.#{selector} == obj.method")
end
end
it_behaves_like('selectors', 'upcase')
it_behaves_like('selectors', 'downcase')
end